Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed docker generation for images that use /bin/sh #2335

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Fixed docker generation for images that use /bin/sh #2335

merged 1 commit into from
Jun 28, 2024

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Jun 28, 2024 •
edited by coderabbitai bot
Loading

Some images, like debian slim, use the /bin/sh which does not provide a source command. This PR replaces source with ..

Summary by CodeRabbit

  • Bug Fixes
    • Improved script execution by updating command paths to use . instead of source.

@cmnrd
Fixed docker generation for images that use /bin/sh
40c49e9 
Some images, like debian slim, use the `/bin/sh` which does not provide a
`source` command. This PR replaces `source` with `.`.
@cmnrd cmnrd added enhancement Enhancement of existing feature docker Issue related to the docker support labels Jun 28, 2024
@cmnrd cmnrd added this to the 0.8.0 milestone Jun 28, 2024
@cmnrd cmnrd requested a review from lhstrh June 28, 2024 14:57
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 28, 2024 •
edited
Loading

Walkthrough

The changes in DockerGenerator.java update script execution commands to use . instead of source. This adjustment affects methods responsible for generating pre-build, post-build, and entry-point commands. The primary aim is to align with common shell scripting practices and enhance compatibility across different environments.

Changes

Files Change Summaries
core/src/main/java/org/lflang/generator/docker/DockerGenerator.java Updated pre-build, post-build, and entry point commands to use . instead of source for script execution.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DockerGenerator
    User->>DockerGenerator: Execute pre-build command
    DockerGenerator->>User: . src-gen/pre-build-script.sh
    
    User->>DockerGenerator: Execute post-build command
    DockerGenerator->>User: . src-gen/post-build-script.sh
    
    User->>DockerGenerator: Execute entry-point command
    DockerGenerator->>User: . scripts/entry-point.sh
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 28, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 73e8c8a and 40c49e9.

Files selected for processing (1)
  • core/src/main/java/org/lflang/generator/docker/DockerGenerator.java (3 hunks)
Files skipped from review due to trivial changes (1)
  • core/src/main/java/org/lflang/generator/docker/DockerGenerator.java

lhstrh
lhstrh approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lhstrh lhstrh added this pull request to the merge queue Jun 28, 2024
Merged via the queue into master with commit 4cb65ff Jun 28, 2024
26 checks passed
@lhstrh lhstrh deleted the docker-source branch June 28, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
docker Issue related to the docker support enhancement Enhancement of existing feature
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cmnrd @lhstrh